[Webkit-unassigned] [Bug 43999] Support JSVALUE32_64 on MIPS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43999


Gabor Loki <loki at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |loki at webkit.org




--- Comment #4 from Gabor Loki <loki at webkit.org>  2010-08-15 23:55:00 PST ---
The patch looks good to me, but I have some questions.

>      struct JITStackFrame {
>          void* reserved; // Unused
> +#if USE(JSVALUE32_64)
> +        void* padding1; // Maintain 8-byte stack alignment.
> +#endif

You could switch the type of 'reserved' member to JITStubArg which is a 32 bits wide data if JSVALUE32 is enabled, and 64 bits wide otherwise. So the alignment of the 'args' should be fine in both cases.

>          JITStubArg args[6];
>  
> +#if USE(JSVALUE32_64)
> +        void* padding2; // Maintain 8-byte stack alignment.
> +#endif
> +

I do not get why it is needed. If 'args' member is aligned, the preservedGP is aligned too.

>          void* preservedGP; // store GP when using PIC code
>          void* preservedS0;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.