[Webkit-unassigned] [Bug 43924] Web Inspector: -[WebInspector attach] and detach should work

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 14 23:22:22 PDT 2010


--- Comment #11 from Joseph Pecoraro <joepeck at webkit.org>  2010-08-14 23:22:22 PST ---
> Thanks for doing this. Afaik Yury was going to fix it pretty much the same way.

Oh. I should have just assigned it to me when I decided I was going to
implement it. I had some spare time tonight.

> I am not sure we should distinguish between backend and front-end on
> the WebKit embedder level. 

I agree, but that I figured distinction already exists because of InspectorClient
and InspectorFrontendClient.

> Otherwise looks good! If you provide the rationale for the interface, I am not
> against putting r+!

My rationale for the extra class was that the extra class is an Obj-C
wrapper around the C++ class. I thought this was a common thing to do, or
at least I had seen the pattern so I felt I should emulate it. I'm fine with
either approach. WebKit clients should still only see and use the
"WebInspector" class. They don't have access to the WebInspectorFrontend.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list