[Webkit-unassigned] [Bug 43924] Web Inspector: -[WebInspector attach] and detach should work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43924


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64436|review?                     |
               Flag|                            |




--- Comment #10 from Pavel Feldman <pfeldman at chromium.org>  2010-08-14 23:07:28 PST ---
(From update of attachment 64436)
Thanks for doing this. Afaik Yury was going to fix it pretty much the same way.

Not sure whether you need this new public abstraction and the delegation. I'd simply place a reference to WebInspectorFrontendClient into WebInspectorPrivate.h. Rationale: WebInspector.h is the api to inspector and I am not sure we should distinguish between backend and front-end on the WebKit embedder level. Otherwise looks good! If you provide the rationale for the interface, I am not against putting r+!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.