[Webkit-unassigned] [Bug 43590] Implementing video frame sharing between WebKit and Chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43590





--- Comment #9 from Victoria <vrk at google.com>  2010-08-13 16:24:15 PST ---
As I mentioned in person, sorry that the code is pretty rough! I didn't write my code with much care line-by-line as I wanted to get the overall design OKed by everyone first. Because of that, it'd probably be best to comment on overall design instead of on nits since I will have to break up the patch and submit it in pieces before I can commit it anyway, at which time I was planning on polishing up the details. An in-depth code review should make more sense/be less painful then, hopefully. :) Thanks so much!

(In reply to comment #8)
> (From update of attachment 63661 [details])
> WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:435
>  +          m_webMediaPlayer->putCurrentFrame(VideoFrameChromiumImpl::toWebVideoFrame(frame));
> probably need a 'delete frame' here.  should document the memory ownership model.
> 
> i have further review comments about style, etc.  will get to those ASAP.
> 
> see also AssertMatchingEnums.cpp.  i think you'll want to extend that for your new enums.
> 
> constants should not have a 'k' prefix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.