[Webkit-unassigned] [Bug 43590] Implementing video frame sharing between WebKit and Chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43590


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63661|review?                     |review-
               Flag|                            |




--- Comment #8 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-08-13 16:02:12 PST ---
(From update of attachment 63661)
WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:435
 +          m_webMediaPlayer->putCurrentFrame(VideoFrameChromiumImpl::toWebVideoFrame(frame));
probably need a 'delete frame' here.  should document the memory ownership model.

i have further review comments about style, etc.  will get to those ASAP.

see also AssertMatchingEnums.cpp.  i think you'll want to extend that for your new enums.

constants should not have a 'k' prefix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.