[Webkit-unassigned] [Bug 43902] flaky websocket/tests/frame-length-overflow.html

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 12 22:22:05 PDT 2010


--- Comment #6 from Fumitoshi Ukai <ukai at chromium.org>  2010-08-12 22:22:05 PST ---
(In reply to comment #5)
> (From update of attachment 64200 [details])
> > +    , m_errorClosed(false)
> I don't like this name, it sounds as if the error itself were somehow closed. When is this variable set to true? If you can explain it in a full English sentence, that may help come up with a good variable name.

how about m_readShutdowned.  It means the channel won't receive any more data, like SHUT_RD.

> > +            skipBuffer(m_bufferSize); // Release buffer. We don't read any more data.
> A comment saying why we're doing this would be more helpful than one saying what we're doing. Is this so save memory?

Yes. and make sure it doesn't read the same buffer again.

> +    if (m_errorClosed)
> +      return false;
> Indentation is incorrect here.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list