[Webkit-unassigned] [Bug 43902] flaky websocket/tests/frame-length-overflow.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43902





--- Comment #5 from Alexey Proskuryakov <ap at webkit.org>  2010-08-12 07:38:43 PST ---
(From update of attachment 64200)
> +    , m_errorClosed(false)

I don't like this name, it sounds as if the error itself were somehow closed. When is this variable set to true? If you can explain it in a full English sentence, that may help come up with a good variable name.

> +            skipBuffer(m_bufferSize); // Release buffer. We don't read any more data.

A comment saying why we're doing this would be more helpful than one saying what we're doing. Is this so save memory?

+    if (m_errorClosed)
+      return false;

Indentation is incorrect here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.