[Webkit-unassigned] [Bug 39617] [GTK] Google sites do not like WebKitGTK+

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39617





--- Comment #24 from Eric Seidel <eric at webkit.org>  2010-08-12 22:08:57 PST ---
(From update of attachment 64252)
My r- is perhaps a bit strong, but this code still seems confused.

WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:171
 +      googleDomains.add("gmail.com");
This always redirects to mail.google.com.  No need for explicit inclusion here.

WebKit/gtk/webkit/webkitwebsettings.cpp:223
 +      DEFINE_STATIC_LOCAL(const String, staticUA, (String::format("Mozilla/5.0 (%s; U; %s; %s) AppleWebKit/%s (KHTML, like Gecko) Version/5.0 Safari/%s",
I'm surprised we don't yet have a version of String::format which can take String objects passed into it.

My only current concern with this patch is that you're casting your net a bit too wide.  Generally with site-specific spoofing the goal is to only spoof for the absolute minimum number of pages, and make it possible for there to be a path away from the spoofing.  I think that Gtk needs this patch (and will probably need it for a long time), but the end goal should be to have a world where this patch is not needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.