[Webkit-unassigned] [Bug 39617] [GTK] Google sites do not like WebKitGTK+

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39617


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64252|review?                     |review-
               Flag|                            |




--- Comment #23 from Eric Seidel <eric at webkit.org>  2010-08-12 22:03:40 PST ---
(From update of attachment 64252)
2     // First we try a full-match, for cases such as 'youtube.com' as opposed to
 193     // 'www.youtube.com'.
 194     if (googleDomains.contains(host))
 195         return true;

That code will never be hit with the current list of domains.

I would not have architected this check this way.

google.* is the only one which want's a "namespace" an only so you can look for the string ".google." and then look up the final tail in a list.  All the other domains only need .com and could have used domain postfixes instead of needing the namespace architecture.

Repeating the string "google." in all of your googleDomains seems unecessary.

The above match against the shortened domain seems wrong in all of the domain examples given.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.