[Webkit-unassigned] [Bug 43848] Need EmptyDeviceOrientationClient and EmptyDeviceMotionClient for use with SVGImage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43848





--- Comment #6 from Jeremy Orlow <jorlow at chromium.org>  2010-08-12 02:22:04 PST ---
(In reply to comment #5)
> I don't know if I like this approach. This is why I filed 
> https://bugs.webkit.org/show_bug.cgi?id=43533
> 
> Rather than create all these empty clients, I think it is better to avoid creating the controller.
> 
> For example, Page::Page could have this:
> 
> : m_deviceMotionController((RuntimeEnabledFeatures::deviceMotionEnabled() && pageClients.deviceMotionClient) ? new DeviceMotionController(pageClients.deviceMotionClient) : 0)
> 
> That way, if the pageClients never gets a deviceMotionClient, then it will not bother constructing a controller. 
> 
> What's the benefit of having an empty client and controller that will never be used?

I thought about that, but it seemed like the precedent is to create empty clients.  Is there something different about this case vs. the others?  Is it worth revisiting the approach on the other clients as well?

I don't really have a strong opinion either way.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.