[Webkit-unassigned] [Bug 43848] Need EmptyDeviceOrientationClient and EmptyDeviceMotionClient for use with SVGImage

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 12 02:05:32 PDT 2010


--- Comment #5 from Dean Jackson <dino at apple.com>  2010-08-12 02:05:32 PST ---
I don't know if I like this approach. This is why I filed 

Rather than create all these empty clients, I think it is better to avoid creating the controller.

For example, Page::Page could have this:

: m_deviceMotionController((RuntimeEnabledFeatures::deviceMotionEnabled() && pageClients.deviceMotionClient) ? new DeviceMotionController(pageClients.deviceMotionClient) : 0)

That way, if the pageClients never gets a deviceMotionClient, then it will not bother constructing a controller. 

What's the benefit of having an empty client and controller that will never be used?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list