[Webkit-unassigned] [Bug 43783] Make CSS Style Selector non-recursive

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43783





--- Comment #6 from Hayato Ito <hayato at chromium.org>  2010-08-10 21:31:38 PST ---
Thank you for the comment.
I'll change the style of this code as you suggested.

I'll also fix styles in other parts of the same file to avoid inconsistency.
I am not sure it is encouraged to include style fixes which are not related to this change. But I'll do it.
If it should be avoided to include style fixes in other parts of same file, please let me know it.


(In reply to comment #5)
> (In reply to comment #4)
> > The style issues are expected ones. Maybe it should be filed as false positives.
> 
> I think it's a good chance to change the style of this code. It seems majority WebKit code is putting '{' just after ':' for case
> 
> % grep 'case.*: {' */*.cpp | wc
>     340    1365   21891
> % grep -B 1 '^ \+{' */*.cpp | grep case | wc
>     113     343    6935
> 
> Also, our style guideline says "Other braces: place the open brace on the line preceding the code block; place the close brace on its own line.".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.