[Webkit-unassigned] [Bug 43783] Make CSS Style Selector non-recursive

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 10 10:09:49 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=43783


Shinichiro Hamaji <hamaji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hamaji at chromium.org




--- Comment #5 from Shinichiro Hamaji <hamaji at chromium.org>  2010-08-10 10:09:49 PST ---
(In reply to comment #4)
> The style issues are expected ones. Maybe it should be filed as false positives.

I think it's a good chance to change the style of this code. It seems majority WebKit code is putting '{' just after ':' for case

% grep 'case.*: {' */*.cpp | wc
    340    1365   21891
% grep -B 1 '^ \+{' */*.cpp | grep case | wc
    113     343    6935

Also, our style guideline says "Other braces: place the open brace on the line preceding the code block; place the close brace on its own line.".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list