[Webkit-unassigned] [Bug 41842] Add feature detection support for NRWT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 10 02:37:57 PDT 2010


Gabor Rapcsanyi <rgabor at inf.u-szeged.hu> changed:

           What    |Removed                     |Added
  Attachment #61033|0                           |1
        is obsolete|                            |

--- Comment #14 from Gabor Rapcsanyi <rgabor at inf.u-szeged.hu>  2010-08-10 02:37:56 PST ---
Created an attachment (id=63993)
 --> (https://bugs.webkit.org/attachment.cgi?id=63993)

There is no platform layer in NRWT. The WebKitPort (webkit.py) inherits from the BasePort (base.py). And the ports like QtPort (qt.py) inherits from WebKitPort. So we have to do the symbol search and etc. in webkit.py as you wrote.
I have changed the patch, now its checks Windows feature support. If other ports want to use on Linux, they just have to define the _path_to_library method like in Qt. On Win platform they have to define _path_to_driver and the Mac platform doesn't use feature detection.
If its ok for you I will make a unit test for it.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list