[Webkit-unassigned] [Bug 43691] Add missing SVGPathSegList source for SVGPathParser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43691





--- Comment #5 from Nikolas Zimmermann <zimmermann at kde.org>  2010-08-10 00:07:56 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 63847 [details] [details])
> 
> > WebCore/svg/SVGPathSegListSource.cpp:138
> >  +      SVGPathSegSingleCoord* quadraticSmooth = static_cast<SVGPathSegSingleCoord*>(m_segment);
> > You can cast to the concrete SVGPathSegCurveToQudaraticSmoothSegment, no?
> 
> Sure, but I want to avoid unneccessary includes here. The same for lineTo and moveTo. All of them need to be included, just to get x and y. Not needed in my eyes.

Ok, you can leave it as is.

(In reply to comment #4)
> 
> With ther type ASSERT you mentioned above, I had to include all these files and have to write something like:
> 
>     ASSERT(static_cast<SVGPathSegType>(m_segment->pathSegType()) == PathSegMoveToAbs
>            || static_cast<SVGPathSegType>(m_segment->pathSegType()) == PathSegMoveToRel);

Not at all, why would you want to cast?
ASSERT(m_segment->pathSegType() == PathSegMoveToAbs || m_segment->pathSegType() == PathSegMoveToRel); would work fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.