[Webkit-unassigned] [Bug 43691] Add missing SVGPathSegList source for SVGPathParser

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 9 23:42:58 PDT 2010


--- Comment #4 from Dirk Schulze <krit at webkit.org>  2010-08-09 23:42:58 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 63847 [details] [details])
> > WebCore/svg/SVGPathSegListSource.cpp:138
> >  +      SVGPathSegSingleCoord* quadraticSmooth = static_cast<SVGPathSegSingleCoord*>(m_segment);
> > You can cast to the concrete SVGPathSegCurveToQudaraticSmoothSegment, no?
> Sure, but I want to avoid unneccessary includes here. The same for lineTo and moveTo. All of them need to be included, just to get x and y. Not needed in my eyes.

With ther type ASSERT you mentioned above, I had to include all these files and have to write something like:

    ASSERT(static_cast<SVGPathSegType>(m_segment->pathSegType()) == PathSegMoveToAbs
           || static_cast<SVGPathSegType>(m_segment->pathSegType()) == PathSegMoveToRel);

for every function :-/

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list