[Webkit-unassigned] [Bug 43750] Fix regression in Mac Chromium UI for audio/video controls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43750





--- Comment #5 from Hin-Chung Lam <hclam at google.com>  2010-08-09 23:10:45 PST ---
(In reply to comment #4)
> (In reply to comment #2)
> > The function change in this patch looks good to me.
> > 
> > It'll break chromium layout tests, but it's ok because those are the correct results.
> > 
> > Please ping jianli@ as he's the webkit sheriff on duty.
> 
> This isn't a great answer. WK gardeners have plenty to do without more being added.
> 
> You have two much better answers:
> Method 1: Provide a new baseline as part of this patch.
> Method 2:
>  * Mark the tests as failing the tests in this patch.
>  * When you are able (to pull the baseline from the canaries), get the new baseline 
>  * Verify it.
>  * Submit a new patch with the new baselines and unmark the tests as failing.

Sorry, I meant to reply to Victoria. I forgot we can use test_expactations.txt to expect failure, thanks for reminding me!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.