[Webkit-unassigned] [Bug 43750] Fix regression in Mac Chromium UI for audio/video controls

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 9 21:39:26 PDT 2010


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
                 CC|                            |levin at chromium.org

--- Comment #4 from David Levin <levin at chromium.org>  2010-08-09 21:39:26 PST ---
(In reply to comment #2)
> The function change in this patch looks good to me.
> It'll break chromium layout tests, but it's ok because those are the correct results.
> Please ping jianli@ as he's the webkit sheriff on duty.

This isn't a great answer. WK gardeners have plenty to do without more being added.

You have two much better answers:
Method 1: Provide a new baseline as part of this patch.
Method 2:
 * Mark the tests as failing the tests in this patch.
 * When you are able (to pull the baseline from the canaries), get the new baseline 
 * Verify it.
 * Submit a new patch with the new baselines and unmark the tests as failing.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list