[Webkit-unassigned] [Bug 43544] [EFL]Implementation dispatchDecidePolicyForNavigationAction

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43544





--- Comment #6 from Ryuan Choi <ryuan.choi at samsung.com>  2010-08-08 19:46:28 PST ---
(In reply to comment #5)
> (From update of attachment 63694 [details])
> I think it looks good. I have one question:
> 
> > +
> > +    PolicyAction policy;
> > +    if (!ret)
> > +        policy = PolicyIgnore;
> > +    else {
> > +        Frame* f = ewk_frame_core_get(m_frame);
> > +        f->loader()->resetMultipleFormSubmissionProtection();
> > +        policy = PolicyUse;
> > +    }
> 
> 
> You are unconditionally calling resetMultipleFormSubmissionProtection() . Should not you do so only with the NavicationAction involves that?
> 
> Se Qt's code below:
> 
>     if (!page->d->acceptNavigationRequest(m_webFrame, r, QWebPage::NavigationType(action.type()))) {
>         if (action.type() == NavigationTypeFormSubmitted || action.type() == NavigationTypeFormResubmitted)
>             m_frame->loader()->resetMultipleFormSubmissionProtection();

Ok, I'll add action related code

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.