[Webkit-unassigned] [Bug 43544] [EFL]Implementation dispatchDecidePolicyForNavigationAction

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43544





--- Comment #5 from Antonio Gomes <tonikitoo at webkit.org>  2010-08-06 09:16:44 PST ---
(From update of attachment 63694)
I think it looks good. I have one question:

> +
> +    PolicyAction policy;
> +    if (!ret)
> +        policy = PolicyIgnore;
> +    else {
> +        Frame* f = ewk_frame_core_get(m_frame);
> +        f->loader()->resetMultipleFormSubmissionProtection();
> +        policy = PolicyUse;
> +    }


You are unconditionally calling resetMultipleFormSubmissionProtection() . Should not you do so only with the NavicationAction involves that?

Se Qt's code below:

    if (!page->d->acceptNavigationRequest(m_webFrame, r, QWebPage::NavigationType(action.type()))) {
        if (action.type() == NavigationTypeFormSubmitted || action.type() == NavigationTypeFormResubmitted)
            m_frame->loader()->resetMultipleFormSubmissionProtection();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.