[Webkit-unassigned] [Bug 42958] Pasting should fire textInput event

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 6 09:24:56 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=42958


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63674|review?                     |review+
               Flag|                            |




--- Comment #8 from Tony Chang <tony at chromium.org>  2010-08-06 09:24:56 PST ---
(From update of attachment 63674)
In general, using enums instead of bools is preferred for readability.  But I realize that some of this is historic for smart replace and match style.  A good follow up patch would be to convert these bools to enums across all the editing code.

WebCore/dom/TextEvent.cpp:56
 +      , m_isBackTab(false)
Nit: Please initialize the bools here too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list