[Webkit-unassigned] [Bug 42958] Pasting should fire textInput event

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42958





--- Comment #7 from MORITA Hajime <morrita at google.com>  2010-08-05 18:31:24 PST ---
Thanks again, Tony! The patch was updated.

> > diff --git a/WebCore/dom/TextEvent.h b/WebCore/dom/TextEvent.h
> > +        static PassRefPtr<TextEvent> createForPlainTextPaste(PassRefPtr<AbstractView> view, const String& data, bool shouldSmartReplace)
> > +        {
> > +            RefPtr<TextEvent> event = adoptRef(new TextEvent(view, data));
> 
> Can you move this body into the .cpp file?
Doe.

> 
> > +            event->setIsPaste(true);
> > +            event->setShouldSmartReplace(shouldSmartReplace);
> 
> Can the member variables change after the TextEvent is created?  If not, maybe we should use constructor arguments and not have set methods.
Sure. moved to the constructor and removed setters.

> One other testing suggestion: Should we add a test to make sure that canceling keydown prevents textInput from firing?  This is mentioned here: http://www.w3.org/TR/DOM-Level-3-Events/#keyset-cancelable_keys
OK, filed Bug 43601 for that. A patch will come shortly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.