[Webkit-unassigned] [Bug 36359] Double clicking page's last editable inline element doesn't select a word.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 6 00:29:46 PDT 2010


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
             Status|UNCONFIRMED                 |NEW
                 CC|                            |rniwa at webkit.org
     Ever Confirmed|0                           |1

--- Comment #31 from Ryosuke Niwa <rniwa at webkit.org>  2010-08-06 00:29:45 PST ---
(In reply to comment #29)
> Created an attachment (id=63698)
 --> (https://bugs.webkit.org/attachment.cgi?id=63698) [details]
> Patch

Are you sure all of your change is well tested?  I'm afraid about changes in visible_units and TextIterator because I've been finding many bugs in those areas and I suspect that there aren't enough tests right now.

Your test seems to only test with mouse events, but your change will affect WebKit's behavior on keyboard events and window.getSelection().modify calls.  I'll really appreciate if you could add more tests.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list