[Webkit-unassigned] [Bug 36359] Double clicking page's last editable inline element doesn't select a word.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36359





--- Comment #30 from MORITA Hajime <morrita at google.com>  2010-08-05 23:33:21 PST ---
Thank you for reviewing,  zimmermann!
I updated the patch.

> LayoutTests/editing/selection/doubleclick-inline-first-last-contenteditable-expected.txt:1
>  +  here to double click, and there
> Very confusing output.
> Can you use the js-test-pre.js / js-test-post.js framework, and create a better test case?

I see. I rewrote it with script test facility.

> 
> That would also avoid having to write your custom log() function.
> WebCore/editing/TextIterator.cpp:275
>  +      // FIXME: should support TextIteratorEndsAtEditingBoundary
> You should file a bug for that, and refer to it here.

Filed at Bug 43609 and pointed it.

> 
> WebCore/editing/TextIterator.cpp:950
>  +      : m_behavior(TextIteratorDefaultBehavior), m_node(0), m_positionNode(0)
> Each initialization belongs in its own line.
Done

> 
> WebCore/editing/TextIterator.cpp:955
>  +      : m_behavior(behavior), m_node(0), m_positionNode(0)
> Ditto.
Done.

> 
> WebCore/editing/TextIterator.h:187
>  +      bool crossesEditingBoundary(Node* node) const;
> You can omit the "node" name here.
Done.

> 
> WebCore/editing/TextIterator.h:188
>  +      bool setCurrentNode(Node* node);
> Ditto.
Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.