[Webkit-unassigned] [Bug 43512] [GTK] Use GSettings to save/restore Web Inspector settings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43512





--- Comment #5 from Gustavo Noronha (kov) <gns at gnome.org>  2010-08-05 06:03:33 PST ---
(In reply to comment #4)
> (From update of attachment 63499 [details])
> Awesome patch!

Thanks =)

> > +gsettings_SCHEMAS = $(srcdir)/WebKit/gtk/org.webkit.gtk.gschema.xml
> 
> Perhaps the identifier should be org.webkitgtk.gschema.xml to match our
> domain name? I'm not sure what the typical procedure is here.

Agreed, makes sense!

> > +GSettings* webkit_get_inspector_g_settings()
> > +{
> > +    static GSettings* settings = g_settings_new("org.webkit.gtk.inspector");
> > +    return settings;
> > +}
> 
> I think it makes sense to follow WebKit-style naming conventions
> for this helper, since it isn't part of the API.

Hmm, yes, I think you are right here as well, though I was thinking this might become convenience API for browsers wanting to track/manipulate the settings, but I guess we can rename/relocate the helper if that turns out to be the case =).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.