[Webkit-unassigned] [Bug 43512] [GTK] Use GSettings to save/restore Web Inspector settings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 4 15:38:44 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=43512





--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2010-08-04 15:38:45 PST ---
(From update of attachment 63499)
Awesome patch!

> +gsettings_SCHEMAS = $(srcdir)/WebKit/gtk/org.webkit.gtk.gschema.xml

Perhaps the identifier should be org.webkitgtk.gschema.xml to match our
domain name? I'm not sure what the typical procedure is here.

> +GSettings* webkit_get_inspector_g_settings()
> +{
> +    static GSettings* settings = g_settings_new("org.webkit.gtk.inspector");
> +    return settings;
> +}

I think it makes sense to follow WebKit-style naming conventions
for this helper, since it isn't part of the API.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list