[Webkit-unassigned] [Bug 40002] Need Geolocation LayoutTest to test case where permission has neither been granted nor denied

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 3 10:47:49 PDT 2010


--- Comment #13 from Steve Block <steveblock at google.com>  2010-08-03 10:47:50 PST ---
> This isn't needed, please don't add this line.
Will fix

> We don't compare to null, so this can be just (m_pendingGeolocationPermissionListeners && !m_timer)
Will fix

> I see that m_pendingGeolocationPermissionListeners is released in timerFired, but shouldn't it be also released in dealloc method - in case the timer doesn't get a chance to fire?
Yes, will fix

> Should we be iterating a copy? It seems that a client might add listeners when handling allow/deny.
No, because listeners are only added before permission has been set. But when the timer fires, the permission must have already been set, as in the assertion above

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list