[Webkit-unassigned] [Bug 40002] Need Geolocation LayoutTest to test case where permission has neither been granted nor denied

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 3 10:28:58 PDT 2010


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #63340|review?                     |review+
               Flag|                            |

--- Comment #12 from Alexey Proskuryakov <ap at webkit.org>  2010-08-03 10:28:58 PST ---
(From update of attachment 63340)
+#import <Foundation/NSSet.h>

This isn't needed, please don't add this line.

+    if (m_pendingGeolocationPermissionListeners != nil && !m_timer)

We don't compare to null, so this can be just (m_pendingGeolocationPermissionListeners && !m_timer)

+        if (!m_pendingGeolocationPermissionListeners)
+            m_pendingGeolocationPermissionListeners = [[NSMutableSet set] retain];

I see that m_pendingGeolocationPermissionListeners is released in timerFired, but shouldn't it be also released in dealloc method - in case the timer doesn't get a chance to fire?

+    NSEnumerator* enumerator = [m_pendingGeolocationPermissionListeners objectEnumerator];

Should we be iterating a copy? It seems that a client might add listeners when handling allow/deny.


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list