[Webkit-unassigned] [Bug 43077] check-webkit-style false positive on T<uint32_t>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43077





--- Comment #4 from Kenichi Ishibashi <bashi at google.com>  2010-08-03 05:58:51 PST ---
(In reply to comment #3)

Hamaji-san,

> So, the real issue isn't T<uint32_t> but new uint32_t ?

I think so. T<uint32_t> isn't the issue at least the case which mentioned on the description. For 'WTF::OwnArrayPtr<uint32_t> buf(new uint32_t[width]);', check-webkit-style could evaluate 'new' as a type of an identifier and uint32_t as an identifier.

> WebKitTools/Scripts/webkitpy/style/checkers/cpp.py:2454
>  +      line = sub(r'new\s*(\(([\w\s:]|::)+\s*[*&]*\s*\))?(?=\W)', '', line)
> Do we really need |:: ? Maybe '(\([\w\s:]+...\))?' would be OK?

I misunderstood the syntax of placement new. |:: isn't  needed here. Thank you letting me know that.

> WebKitTools/Scripts/webkitpy/style/checkers/cpp.py:2454
>  +      line = sub(r'new\s*(\(([\w\s:]|::)+\s*[*&]*\s*\))?(?=\W)', '', line)
> Why do we need (?=\W) ?

Here I also misunderstood the syntax, too. (?=\W) isn't needed here.

I'll send revised patch soon. Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.