[Webkit-unassigned] [Bug 43077] check-webkit-style false positive on T<uint32_t>

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 3 05:28:35 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=43077





--- Comment #3 from Shinichiro Hamaji <hamaji at chromium.org>  2010-08-03 05:28:34 PST ---
(From update of attachment 63326)
So, the real issue isn't T<uint32_t> but new uint32_t ?

WebKitTools/Scripts/webkitpy/style/checkers/cpp.py:2454
 +      line = sub(r'new\s*(\(([\w\s:]|::)+\s*[*&]*\s*\))?(?=\W)', '', line)
Do we really need |:: ? Maybe '(\([\w\s:]+...\))?' would be OK?

WebKitTools/Scripts/webkitpy/style/checkers/cpp.py:2454
 +      line = sub(r'new\s*(\(([\w\s:]|::)+\s*[*&]*\s*\))?(?=\W)', '', line)
Why do we need (?=\W) ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list