[Webkit-unassigned] [Bug 43221] Move WebGL-specific code out of GraphicsContext3D so that G3D can be used as a generic accelerated drawing API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43221


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63297|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #6 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-08-02 23:11:58 PST ---
(From update of attachment 63297)
WebCore/html/canvas/WebGLRenderingContext.cpp:223
 +      m_context->attachShader(program ? program->object() : 0, shader ? shader->object() : 0);
This null checking of program seems unnecessary given the null
test done by validateWebGLObject.  hmm... should validateWebGLObject
be modified to also null check program->object()?  same goes for
the rest of the null checking in this file.

WebCore/html/canvas/WebGLRenderingContext.cpp:330
 +                  static const int kTextureWrapR = 0x8072;
nit: kTextureWrapR -> textureWrapR


otherwise, R=me

this is very nice cleanup of GC3D.  it was always bothersome that
code in platform/graphics depended back on code in html/canvas.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.