[Webkit-unassigned] [Bug 38324] [Qt] Fix compilation with QT_NO_FEATURE

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38324


Tasuku Suzuki <tasuku.suzuki at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54803|0                           |1
        is obsolete|                            |
  Attachment #54803|review?, commit-queue?      |
               Flag|                            |
  Attachment #54847|                            |review?, commit-queue?
               Flag|                            |




--- Comment #9 from Tasuku Suzuki <tasuku.suzuki at nokia.com>  2010-04-30 22:53:08 PST ---
Created an attachment (id=54847)
 --> (https://bugs.webkit.org/attachment.cgi?id=54847)
Patch to fix compilation with QT_NO_LINEEDIT

(In reply to comment #8)
> (From update of attachment 54803 [details])
> WebCore/platform/qt/RenderThemeQt.cpp:278
>  +      return style->pixelMetric(QStyle::PM_DefaultFrameWidth, &opt, 0);
> I prefer this style as:
> 
> #ifndef NO_LINE_EDIT
>     QtLineEdit lineEdit = 0;
> #else
>    QtLineEdit* lineEdit = m_lineEdit;
> #end
> because then the long call doesn't have to be copied twice.
> 
> Otherwise this looks fine.  Even looks OK as is, I just prefer less copy/paste
> code.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.