[Webkit-unassigned] [Bug 38324] [Qt] Fix compilation with QT_NO_FEATURE
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 30 11:55:25 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=38324
--- Comment #8 from Eric Seidel <eric at webkit.org> 2010-04-30 11:55:24 PST ---
(From update of attachment 54803)
WebCore/platform/qt/RenderThemeQt.cpp:278
+ return style->pixelMetric(QStyle::PM_DefaultFrameWidth, &opt, 0);
I prefer this style as:
#ifndef NO_LINE_EDIT
QtLineEdit lineEdit = 0;
#else
QtLineEdit* lineEdit = m_lineEdit;
#end
because then the long call doesn't have to be copied twice.
Otherwise this looks fine. Even looks OK as is, I just prefer less copy/paste
code.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list