[Webkit-unassigned] [Bug 34005] Safari pegs CPU and drops tons of frames using HTML5 Vimeo player

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34005


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54600|review?                     |review-
               Flag|                            |




--- Comment #52 from Sam Weinig <sam at webkit.org>  2010-04-30 18:03:25 PST ---
(From update of attachment 54600)
WebCore/platform/graphics/win/QTMovie.cpp:266
 +          m_private->m_clients.remove(indexOfClient);
Is this correct?  Do you really never want to remove the first client?

WebCore/platform/graphics/win/QTMovie.h:60
 +  class QTMOVIEWIN_API QTMovie : public RefCounted<QTMovie> {
It seems like this class should be renamed something like QTMovieView or
QTMovieGWorld.  If you don't want to rename it in this round, please add a
comment.

WebCore/platform/graphics/win/QTMovieTask.cpp:46
 +      static QTMovieTask* s_sharedTask = new QTMovieTask();
This should use the DEFINE_GLOBAL macro.

r=me but please consider those
changes.WebCore/platform/graphics/win/QTMovieWin.h:75
 +      RefPtr<QTMovie> movie() const;
We don't ever pass or return RefPtr's.  Please see
http://webkit.org/coding/RefPtr.html for more on that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.