[Webkit-unassigned] [Bug 33119] svn-apply breaks on patch files with leading white space

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33119





--- Comment #6 from Zoltan Horvath <zoltan at webkit.org>  2010-04-30 06:32:56 PST ---
(In reply to comment #5)
> (From update of attachment 52855 [details])
> Marking this patch r- because it no longer applies.
> 
> Also, some high-level comments regarding the directory being created here:
> 
> > +++ WebKitTools/Scripts/webkitperl/tools_unittest/svn-apply.pl	(revision 0)
> 
> Might it make more sense to continue the existing pattern of one *_unittest/
> directory per file to be unit-tested?  For example, svn-apply_unittest/ and
> svn-unapply_unittest/?

I don't like dir/unittest direction. I think it's more perspicuous to have only
one unittest for a file, so directories're needless.

> If code can be shared between tests of code in svn-apply and svn-unapply,
> maybe that can be handled by adding a test-support file in webkitperl/.
>
> Finally, in cases where svn-apply and svn-unapply define the same or nearly
> the same methods (because of cut-and-paste), it may also make sense to
> refactor those areas to use the same code.  Then for each refactored
> function, one function can be unit-testted instead of two.  That's not
> something you necessarily need to be the one to do, but it's something
> to consider.

I considered this earlier, and I agree with merging the two files into one. (I
opened a bug: bug #38388 ) So first, we should try to refactoring it, and then
as you said there will be only unit-test. If it's okay, next week I'll try to
allocate some time for this. :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.