[Webkit-unassigned] [Bug 33119] svn-apply breaks on patch files with leading white space

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33119





--- Comment #7 from Chris Jerdonek <cjerdonek at webkit.org>  2010-04-30 09:51:12 PST ---
(In reply to comment #6)
> > Might it make more sense to continue the existing pattern of one *_unittest/
> > directory per file to be unit-tested?  For example, svn-apply_unittest/ and
> > svn-unapply_unittest/?
> 
> I don't like dir/unittest direction. I think it's more perspicuous to have only
> one unittest for a file, so directories're needless.

A directory was created for VCSUtils.pm's unit tests to avoid having a single
monster file.  VCSUtils.pm is up to around 37 subroutines, and some of those
subroutines need many lines to test since the inputs and outputs are patch
strings.  For example, the unit test file for the parseDiff() subroutine is
over 300 lines not counting the initial license text.  And that may grow as we
add support for other patch syntax like SVN properties, etc.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.