[Webkit-unassigned] [Bug 38286] Need to call FrameView::scrollPositionChanged when changing the scroll position when the ScrollView does not have a platformWidget

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 29 12:43:38 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38286





--- Comment #13 from Benjamin Poulain <benjamin.poulain at nokia.com>  2010-04-29 12:43:37 PST ---
(In reply to comment #12)
> Simon Fraser suggested that it might be better to  move the
> scrollPositionChanged() call from being public on FrameView to being public on
> ScrollView.  The current only callsite to this is the mac platform layer here:
> http://trac.webkit.org/browser/trunk/WebKit/mac/WebView/WebHTMLView.mm#L1162. 
> I'm happy to move the function if it makes sense, but I'm less familiar with
> how this code is supposed to interact with the port layer.

I am not sure to understand what you mean. 

You cannot implement scrollPositionChanged() in ScrollView because you need to
access the frame.

If you mean have scrollPositionChanged() public in ScrollView instead of
Private, the I don't have anything against it :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list