[Webkit-unassigned] [Bug 38286] Need to call FrameView::scrollPositionChanged when changing the scroll position when the ScrollView does not have a platformWidget

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 29 12:32:54 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38286





--- Comment #12 from James Robinson <jamesr at chromium.org>  2010-04-29 12:32:54 PST ---
Thanks for the feedback, Benjamin.  I've moved the scrollPositionChanged() call
as you suggested.  I plan to grab new expectations for
fast/repaint/fixed-move-after-keyboard-scroll.html off of the bots after
landing.

Simon Fraser suggested that it might be better to  move the
scrollPositionChanged() call from being public on FrameView to being public on
ScrollView.  The current only callsite to this is the mac platform layer here:
http://trac.webkit.org/browser/trunk/WebKit/mac/WebView/WebHTMLView.mm#L1162. 
I'm happy to move the function if it makes sense, but I'm less familiar with
how this code is supposed to interact with the port layer.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list