[Webkit-unassigned] [Bug 37981] implement getData('text/html') for webkit win

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37981


Jian Li <jianli at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54123|review?                     |review-
               Flag|                            |




--- Comment #13 from Jian Li <jianli at chromium.org>  2010-04-29 11:51:42 PST ---
(From update of attachment 54123)
LayoutTests/ChangeLog:6
 +          https://bugs.webkit.org/show_bug.cgi?id=37981
Please also mention that 2 layout tests are rebaselined due to the reason you
spoke of.

WebCore/platform/win/ClipboardUtilitiesWin.cpp:394
 +  String getTextHTML(IDataObject* data, bool& success)
It might be better to define the function as:
  bool getTextHTML(IDataObject* data, String& result)

WebCore/platform/win/ClipboardUtilitiesWin.cpp:409
 +  String getCFHTML(IDataObject* data, bool& success)
ditto.

WebCore/platform/win/ClipboardUtilitiesWin.cpp:466
 +      if (SUCCEEDED(data->GetData(htmlFormat(), &store))) {
This and the following line seem to be identical to getCFHTML. Can you change
to call the helper function?

WebCore/platform/win/PasteboardWin.cpp:295
 +              PassRefPtr<DocumentFragment> fragment =
fragmentFromCFHTML(frame->document(), cf_html);
Please also update the name "cf_html".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.