[Webkit-unassigned] [Bug 38180] Remove unneeded custom code for WebSocket.send

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38180





--- Comment #9 from Sam Weinig <sam at webkit.org>  2010-04-27 15:18:43 PST ---
(In reply to comment #8)
> (From update of attachment 54393 [details])
> > It seems much better to have it work the same way as every other method.
> 
> I don't have a big problem with this change in behavior per se. But I have two
> problems with this patch:
> 1. Since it's a behavior change, there should be tests.
> 2. The "every other method" explanation doesn't really hold water. As I
> mentioned, there are hundreds of cases where we do the same as the code you are
> changing does. Those may be a minority, but not a negligible minority.

I have to agree with Alexey on this one and would add that we should aim to
separate cleanup from functionality change.  And to reiterate, any
functionality change here should be tested.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.