[Webkit-unassigned] [Bug 38180] Remove unneeded custom code for WebSocket.send

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38180


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54393|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #8 from Alexey Proskuryakov <ap at webkit.org>  2010-04-27 11:29:36 PST ---
(From update of attachment 54393)
> It seems much better to have it work the same way as every other method.

I don't have a big problem with this change in behavior per se. But I have two
problems with this patch:
1. Since it's a behavior change, there should be tests.
2. The "every other method" explanation doesn't really hold water. As I
mentioned, there are hundreds of cases where we do the same as the code you are
changing does. Those may be a minority, but not a negligible minority.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.