[Webkit-unassigned] [Bug 38180] Remove unneeded custom code for WebSocket.send

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38180


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sam at webkit.org




--- Comment #6 from Alexey Proskuryakov <ap at webkit.org>  2010-04-27 10:54:48 PST ---
> Is that code correct?  Why do we do that here but not everywhere else we
> convert arguments to strings?

We do that sometimes. In particular, we do that elsewhere in WebSocket bindings
code (e.g. constructWebSocket()).

> Why do we check args.size() here?  That's very rare in our bindings

Searching for "if (args.size()" reveals many cases where we check for the
number of arguments.

I don't have good answers to those questions. It's not unthinkable that most of
WebKit code is wrong in this respect. Given that IE and Firefox diverge a lot,
and WebIDL is just a working draft, it's hard to even define"right" and
"wrong".

Providing better error reporting and catching exceptions from argument
conversion early both seem to be generally good things to do, although there's
of course the question of how these affect performance.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.