[Webkit-unassigned] [Bug 38180] Remove unneeded custom code for WebSocket.send

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38180





--- Comment #5 from Adam Barth <abarth at webkit.org>  2010-04-27 10:22:47 PST ---
The old code looks wrong.  (In reply to comment #4)
> -    if (exec->hadException())
> -        return throwError(exec, SyntaxError, "bad message data.");
> 
> How is this going to be autogenerated?

Is that code correct?  Why do we do that here but not everywhere else we
convert arguments to strings?

> > Seems like we should write a layout test to explain the badness?
> 
> I'm confused - this bug sounds like it shouldn't change behavior, how can one
> make a layout test for that?

- if (args.size() < 1)

Why do we check args.size() here?  That's very rare in our bindings and usually
reserved for when we need it for web compat.  Our general philosophy is that
args that aren't given are treated as undefined.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.