[Webkit-unassigned] [Bug 37987] [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37987





--- Comment #30 from Eric Seidel <eric at webkit.org>  2010-04-27 01:59:10 PST ---
(In reply to comment #29)
> (From update of attachment 54395 [details])
> WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:128
>  +      # FIXME: Callers should use scm.py instead.
> This comment seems unrelated, but ok.

Yeah, I just noticed more of the scm duplication while in the file.

> WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:139
>  +                                        shell=(sys.platform == 'win32'),
> I thought we were against shell=True?

We are.

> WebKitTools/Scripts/webkitpy/layout_tests/port/server_process.py:73
>  +          close_fds = sys.platform not in ('win32', 'cygwin')
> This seems to be a repeat of the code in Executive.  Is there a way for them to
> share?

server_process keeps a long-running Popen().  Executive does not yet have any
sort of wrapper for that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.