[Webkit-unassigned] [Bug 37987] [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37987


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54395|review?                     |review+
               Flag|                            |




--- Comment #29 from Adam Barth <abarth at webkit.org>  2010-04-27 01:48:37 PST ---
(From update of attachment 54395)
WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:128
 +      # FIXME: Callers should use scm.py instead.
This comment seems unrelated, but ok.

WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:139
 +                                        shell=(sys.platform == 'win32'),
I thought we were against shell=True?

WebKitTools/Scripts/webkitpy/layout_tests/port/server_process.py:73
 +          close_fds = sys.platform not in ('win32', 'cygwin')
This seems to be a repeat of the code in Executive.  Is there a way for them to
share?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.