[Webkit-unassigned] [Bug 38160] <input type="search"> with uneven padding causes text clipping

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38160


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joepeck at webkit.org




--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org>  2010-04-26 22:09:17 PST ---
> > +    RenderBox* renderer = static_cast<RenderBox*>(m_innerBlock->renderer());
> 
> 0. You should use m_innerBlock->renderBox() instead of the unsafe cast.

Fixed.


> 1. RenderTextControl’s override of hasControlClip() is redundant since it
> returns false just like the base class.

Fixed. Good Catch.


> 2. RenderTextControl’s implementation of controlClipRect() is used only by
> RenderTextControlSingleLine instances.

Removed.


> 3. RenderTextControlSingleLine::paint() uses contentBoxRect() to paint the caps
> lock indicator and is therefore similarly broken with uneven padding (the
> indicator renders at the top instead of at the middle).

Fixed. Great Catch!


> 4. I don’t really understand the logic of
> RenderTextControlSingleLine::hasControlClip(): it allows things like
>       <input value="overflow" style="height: 20px; font-size: 24px;">
>    which seem quite wrong.

Could you explain? hasControlClip is something like "return m_cancelButton"
which only happens if the element is a search field (or maybe has a
-webkit-appearance value). I don't think the case you mentioned would be
affected.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.