[Webkit-unassigned] [Bug 38160] <input type="search"> with uneven padding causes text clipping

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38160


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54372|review?                     |review-
               Flag|                            |




--- Comment #3 from mitz at webkit.org  2010-04-26 20:25:42 PST ---
(From update of attachment 54372)
> +    RenderBox* renderer = static_cast<RenderBox*>(m_innerBlock->renderer());

0. You should use m_innerBlock->renderBox() instead of the unsafe cast.

I noticed some problems while reviewing this patch:

1. RenderTextControl’s override of hasControlClip() is redundant since it
returns false just like the base class.
2. RenderTextControl’s implementation of controlClipRect() is used only by
RenderTextControlSingleLine instances.
3. RenderTextControlSingleLine::paint() uses contentBoxRect() to paint the caps
lock indicator and is therefore similarly broken with uneven padding (the
indicator renders at the top instead of at the middle).
4. I don’t really understand the logic of
RenderTextControlSingleLine::hasControlClip(): it allows things like
      <input value="overflow" style="height: 20px; font-size: 24px;">
   which seem quite wrong.

r- since I suspect you’ll want to address item 0 and perhaps some of the
others.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.