[Webkit-unassigned] [Bug 38128] Don't add empty credential to CredentialStorage.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38128





--- Comment #5 from Yongjun Zhang <yongjun_zhang at apple.com>  2010-04-26 13:43:40 PST ---
(In reply to comment #4)
> (From update of attachment 54318 [details])
> This patch only modifies one code path, avoiding badness in
> CredentialStorage::set() on some platforms. I think that it would be better for
> consistency to add an early return regardless of OS X version, something like 
> 
>     if (credential.isEmpty()) {
>         clearAuthentication();
>         return;
>     }

Hmm.. Wouldn't that make WebCore loading stay at a undefined state?  For
example, the progress bar is started because user clicks a link which leads to
a page requires authentication.  Then the challenge comes and user enters an
empty credential, then we just bail out early without sending the _invalid_
credential out.  I believe the progress bar will stay running because the
FrameLoader is not notified in any way in this case.

so I might need to change to something like:
if (credential.isEmpty()) {
     m_client->cancel(ResourceError);   // tell the FrameLoader to clear the
Provisional Load and stop the progress bar.
     clearAuthentiation();
     return;
}

>  +          No new tests added because it doesn't change the current behavior.
> 
> I think that that a more accurate explanation would be "because this only
> affects credentials entered by the user, and we cannot test authentication
> dialog in DumpRenderTree".

Good point! I will update the Changelog.

> We need to make the same changes on Windows, but that can be a separate patch
> that someone (possibly myself) can make later.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.