[Webkit-unassigned] [Bug 38128] Don't add empty credential to CredentialStorage.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38128


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54318|review?                     |review-
               Flag|                            |




--- Comment #4 from Alexey Proskuryakov <ap at webkit.org>  2010-04-26 12:16:36 PST ---
(From update of attachment 54318)
This patch only modifies one code path, avoiding badness in
CredentialStorage::set() on some platforms. I think that it would be better for
consistency to add an early return regardless of OS X version, something like 

    if (credential.isEmpty()) {
        clearAuthentication();
        return;
    }

 +          No new tests added because it doesn't change the current behavior.

I think that that a more accurate explanation would be "because this only
affects credentials entered by the user, and we cannot test authentication
dialog in DumpRenderTree".

We need to make the same changes on Windows, but that can be a separate patch
that someone (possibly myself) can make later.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.