[Webkit-unassigned] [Bug 37905] Rendering SVGs through img elements is slow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37905





--- Comment #4 from Simon Hausmann <hausmann at webkit.org>  2010-04-20 21:58:18 PST ---
(In reply to comment #3)
> (From update of attachment 53909 [details])
> 
> > +    if (s.width() * s.height() < 1024*1024) {
> 
> I guess this is the why you dont pass the coding style. Space needed around the
> *. That needs fixing.
> 
> > Image* cachedImage = svgAsCachedImage();
> 
> so svgAsCachedImage creates a cached representation and stores it internally?
> Maybe use a better name.

How about toCachedImage()?

> Maybe you could merge the two lines:
> 
> 182         Image* cachedImage = svgAsCachedImage();
>  183         if (cachedImage) {

That's a good idea.

> Apart from that looks good.

Thanks for the review.

Dirk, any thoughts from your side about this optimization in general?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.